[PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
Christoph Hellwig
hch at lst.de
Tue Jun 11 21:45:58 PDT 2024
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
> > - if (!sd_is_zoned(sdkp))
> > + if (!sd_is_zoned(sdkp)) {
> > + lim->zoned = false;
>
> Maybe we should clear the other zone related limits here ? If the drive is
> reformatted/converted from SMR to CMR (FORMAT WITH PRESET), the other zone
> limits may be set already, no ?
Yes, but we would not end up here. The device type is constant over
the struct of the scsi_device and we'd have to fully reprobe it.
So we don't need to clear any flags, including the actual zoned flag
here.
More information about the linux-um
mailing list