[PATCH] um: line: always fill *error_out in setup_one_line()

[Anton Ivanov]

On 03/07/2024 16:22, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg at intel.com>
> 
> The pointer isn't initialized by callers, but I have
> encountered cases where it's still printed; initialize
> it in all possible cases in setup_one_line().
> 
> Signed-off-by: Johannes Berg <johannes.berg at intel.com>
> ---
>   arch/um/drivers/line.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
> index d82bc3fdb86e..43d8959cc746 100644
> --- a/arch/um/drivers/line.c
> +++ b/arch/um/drivers/line.c
> @@ -383,6 +383,7 @@ int setup_one_line(struct line *lines, int n, char *init,
>   			parse_chan_pair(NULL, line, n, opts, error_out);
>   			err = 0;
>   		}
> +		*error_out = "configured as 'none'";
>   	} else {
>   		char *new = kstrdup(init, GFP_KERNEL);
>   		if (!new) {
> @@ -406,6 +407,7 @@ int setup_one_line(struct line *lines, int n, char *init,
>   			}
>   		}
>   		if (err) {
> +			*error_out = "failed to parse channel pair";
>   			line->init_str = NULL;
>   			line->valid = 0;
>   			kfree(new);

Acked-By: Anton Ivanov <anton.ivanov at cambridgegreys.com>
-- 
Anton R. Ivanov
https://www.kot-begemot.co.uk/