[PATCH v3 08/13] um: nommu: configure fs register on host syscall invocation

Johannes Berg johannes at sipsolutions.net
Wed Dec 4 08:52:44 PST 2024


On Tue, 2024-12-03 at 13:23 +0900, Hajime Tazaki wrote:
> 
> +static int os_x86_arch_prctl(int pid, int option, unsigned long *arg2)
> +{
> +	if (host_has_fsgsbase) {
> +		switch (option) {
> +		case ARCH_SET_FS:
> +			wrfsbase(*arg2);
> +			break;
> +		case ARCH_SET_GS:
> +			wrgsbase(*arg2);
> +			break;
> +		case ARCH_GET_FS:
> +			*arg2 = rdfsbase();
> +			break;
> +		case ARCH_GET_GS:
> +			*arg2 = rdgsbase();
> +			break;
> +		}
> +		return 0;
> +	} else {

Even checkpatch complains about else after return :) No need.

Also here, I think need better separation of MMU/no-MMU code. Perhaps
some of the functions should have "nommu" in the name too, and be
otherwise empty inlines.

johannes



More information about the linux-um mailing list