-Wmissing-prototypes warnings in user-mode linux

[Tiwei Bie]

Hi Richard,

On 4/23/24 4:35 AM, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "Jani Nikula" <jani.nikula at intel.com>
>> An: "Johannes Berg" <johannes at sipsolutions.net>, "richard" <richard at nod.at>, "anton ivanov"
>>> I think this series addressed most already?
>>>
>>> https://patchwork.ozlabs.org/project/linux-um/list/?series=393619
>>>
>>> But I haven't checked myself yet.
>>
>> Oh, nice, it certainly helps!
>>
>> But after applying that in my branch, I do still get a bunch of
>> warnings.
> 
> Exactly.
> 
> Tiwei Bie, with your v3 series[0] applied,
> I still see the following build warnings:

Thanks for trying that series! As stated in its cover letter [0], some
remaining -Wmissing-prototypes warnings are as expected.

That series includes only the straightforward fixes and has addressed
a large portion of the -Wmissing-prototypes warnings.

I plan to fix the remaining warnings in a separate smaller followup series.
But the fixes in it might not be as straightforward, and some might be
contentious. I will post it tonight or tomorrow.

[0] https://patchwork.ozlabs.org/project/linux-um/cover/20240306101925.1088870-1-tiwei.btw@antgroup.com/

Regards,
Tiwei

> arch/x86/um/signal.c:559:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
>   559 | long sys_rt_sigreturn(void)
>       |      ^~~~~~~~~~~~~~~~
> arch/um/os-Linux/mem.c:28:6: warning: no previous prototype for ‘kasan_map_memory’ [-Wmissing-prototypes]
>    28 | void kasan_map_memory(void *start, size_t len)
>       |      ^~~~~~~~~~~~~~~~
> arch/um/os-Linux/mem.c:212:13: warning: no previous prototype for ‘check_tmpexec’ [-Wmissing-prototypes]
>   212 | void __init check_tmpexec(void)
>       |             ^~~~~~~~~~~~~
> arch/x86/um/os-Linux/registers.c:146:15: warning: no previous prototype for ‘get_thread_reg’ [-Wmissing-prototypes]
>   146 | unsigned long get_thread_reg(int reg, jmp_buf *buf)
>       |               ^~~~~~~~~~~~~~
> arch/um/os-Linux/skas/process.c:107:6: warning: no previous prototype for ‘wait_stub_done’ [-Wmissing-prototypes]
>   107 | void wait_stub_done(int pid)
>       |      ^~~~~~~~~~~~~~
> arch/um/os-Linux/skas/process.c:683:6: warning: no previous prototype for ‘__switch_mm’ [-Wmissing-prototypes]
>   683 | void __switch_mm(struct mm_id *mm_idp)
>       |      ^~~~~~~~~~~
> arch/x86/um/vdso/um_vdso.c:16:5: warning: no previous prototype for ‘__vdso_clock_gettime’ [-Wmissing-prototypes]
>    16 | int __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
>       |     ^~~~~~~~~~~~~~~~~~~~
> arch/x86/um/vdso/um_vdso.c:30:5: warning: no previous prototype for ‘__vdso_gettimeofday’ [-Wmissing-prototypes]
>    30 | int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
>       |     ^~~~~~~~~~~~~~~~~~~
> arch/x86/um/vdso/um_vdso.c:44:21: warning: no previous prototype for ‘__vdso_time’ [-Wmissing-prototypes]
>    44 | __kernel_old_time_t __vdso_time(__kernel_old_time_t *t)
>       |                     ^~~~~~~~~~~
> arch/x86/um/vdso/um_vdso.c:57:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
>    57 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
>       | ^~~~~~~~~~~~~
> 
> [0] https://patchwork.ozlabs.org/project/linux-um/list/?series=397986
> 
> Thanks,
> //richard