[PATCH] um: tlb: Remove unused flush_tlb_mm_range function
Tiwei Bie
tiwei.btw at antgroup.com
Sun Apr 14 19:18:31 PDT 2024
On 4/15/24 5:19 AM, Ivan Orlov wrote:
> GCC 11.4.0 produces the following warning when compiling the kernel for
> UML architecture (with UML defconfig):
>
> arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
> 579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,)
>
> This function is not used anywhere. It is not exported with
> `EXPORT_SYMBOL` either, and therefore it is not usable for dynamically
> loaded modules. Remove this function.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322 at gmail.com>
> ---
> arch/um/kernel/tlb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c
> index 7d050ab0f78a..70b5e47e9761 100644
> --- a/arch/um/kernel/tlb.c
> +++ b/arch/um/kernel/tlb.c
> @@ -576,12 +576,6 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
> }
> EXPORT_SYMBOL(flush_tlb_range);
>
> -void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
> - unsigned long end)
> -{
> - fix_range(mm, start, end, 0);
> -}
> -
> void flush_tlb_mm(struct mm_struct *mm)
> {
> struct vm_area_struct *vma;
Thanks for the patch. I also posted a fix for this earlier (but not merged yet):
https://lore.kernel.org/linux-um/20240306101925.1088870-4-tiwei.btw@antgroup.com/
Regards,
Tiwei
More information about the linux-um
mailing list