[PATCH v3] um: vector: Replace undo_user_init in old code with out_free_netdev

Markus Elfring Markus.Elfring at web.de
Tue Jul 4 01:10:38 PDT 2023


> Thanks for your response and suggestions,
> I made some mistakes. This is a resubmitted patch.

You present a need for further improvements.


> I got some errors with my local repository,
> so I lost the commit SHA-1 ID.

I wonder about such information here.


> Fixes: ("drivers: use free_netdev before return in vector_eth_configure()")

Please provide a missing detail.


> Please check this link to see previous replies.
> Link: https://lore.kernel.org/all/8854675f-99e7-314e-c986-8dc954ee4a27@web.de/

Would a subject like “[PATCH v4] um: vector: Fix exception handling in vector_eth_configure()”
be more appropriate?


> This patch make out_free_netdev replace undo_user_init,
> fix etherdev leak in error return path.

The resource cleanup was incomplete in the implementation of the function “vector_eth_configure”.
Thus replace the jump target “out_undo_user_init” by “out_free_netdev”.


…
> ---
>  arch/um/drivers/vector_kern.c | 4 +---
…

I would appreciate further version descriptions here.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n698

Regards,
Markus



More information about the linux-um mailing list