[PATCH 2/2] IB/rdmavt: modify rdmavt/qp.c for UML
Johannes Berg
johannes at sipsolutions.net
Tue Jan 4 00:43:17 PST 2022
On Tue, 2022-01-04 at 08:03 +0000, Anton Ivanov wrote:
> >
> > > Why are you trying to make a HW driver compile on UML? Is there any
> > > way to even use a driver like this in a UML environment?
> >
> > I'm just trying to clean up lots of UML build errors.
> > I'm quite happy just making the driver depend on !UML.
> >
> > UML maintainers, what do you think?
> >
> > Thanks again.
> >
>
> I would suggest that we just !UML this driver.
>
Agree, unless some of the maintainers of this driver actually wants to
build simulation for it for testing or something, it's almost certainly
completely useless.
After all, the reason I enabled PCI on UML was to be able to test - in
simulation - PCI driver code in UML... Most certainly nobody wants to do
that here, so it's pointless to let the driver be compiled.
OTOH, as Christoph points out, that seems like a band-aid for some
really strange code, but it's probably the easiest way to get the build
issue fixed in the short term.
johannes
More information about the linux-um
mailing list