[PATCH 3/3] um: stub_32.h: move 'inline' before 'void' to fix W=1 warning

Randy Dunlap rdunlap at infradead.org
Wed Apr 14 07:43:50 BST 2021


Use the expected ordering of function modifier keywords.

arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
 static void inline remap_stack_and_trap(void)
 ^~~~~~

Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Reported-by: kernel test robot <lkp at intel.com>
Cc: Jeff Dike <jdike at addtoit.com>
Cc: Richard Weinberger <richard at nod.at>
Cc: Anton Ivanov <anton.ivanov at cambridgegreys.com>
Cc: linux-um at lists.infradead.org
---
 arch/x86/um/shared/sysdep/stub_32.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210413.orig/arch/x86/um/shared/sysdep/stub_32.h
+++ linux-next-20210413/arch/x86/um/shared/sysdep/stub_32.h
@@ -77,7 +77,7 @@ static inline void trap_myself(void)
 	__asm("int3");
 }
 
-static void inline remap_stack_and_trap(void)
+static inline void remap_stack_and_trap(void)
 {
 	__asm__ volatile (
 		"movl %%esp,%%ebx ;"



More information about the linux-um mailing list