[PATCH 0/7 um: IRQ handling cleanups

Johannes Berg johannes at sipsolutions.net
Tue Nov 24 03:58:55 EST 2020


On Tue, 2020-11-24 at 09:55 +0100, Johannes Berg wrote:
> 
> > I have tried some of what you did when working on timers/epoll -
> > namely turning off the HZ-like nanosleep in time.c. I could not get it
> > to work at the time. So I dropped it from the final version of the
> > patches.
> 
> That one's just weird ... and unnecessary. I can't see why it could
> possibly matter.

Or actually ... wait? I thought you were referring to "um: simplify
os_idle_sleep() and sleep longer" but that's not in this set now...

Anyway, if you were indeed referring to that patch, it's not strictly
needed - removing it would just mean I couldn't call os_idle_sleep() for
suspend but would have to add os_suspend() or something. OTOH, it didn't
break anything for me (neither time-travel nor normal mode), and I can't
see how it was necessary since if clock_nanosleep() (or now select())
was interrupted by a signal and returned, the signal handler ran too...

johannes




More information about the linux-um mailing list