[PATCH v1] um: Increase stack frame size threshold for signal.c

David Gow davidgow at google.com
Wed Dec 9 18:35:59 EST 2020


On Thu, Dec 10, 2020 at 2:23 AM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> The signal.c can't use heap for bit data located on stack. However,
> by default a compiler warns us about overstepping stack frame size
> threshold:
>
> arch/um/os-Linux/signal.c: In function ‘sig_handler_common’:
> arch/um/os-Linux/signal.c:51:1: warning: the frame size of 2960 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>    51 | }
>       | ^
> arch/um/os-Linux/signal.c: In function ‘timer_real_alarm_handler’:
> arch/um/os-Linux/signal.c:95:1: warning: the frame size of 2960 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>     95 | }
>        | ^
>
> Due to above increase stack frame size threshold explicitly for signal.c
> to avoid unnecessary warning.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
Thanks -- this has been annoying me for a while!

I've tested it -- the warning is indeed gone, and nothing else seems to break.

Tested-by: David Gow <davidgow at google.com>

Cheers,
-- David



More information about the linux-um mailing list