[PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together

Christoph Hellwig hch at infradead.org
Wed Oct 9 23:54:11 PDT 2024


On Wed, Oct 09, 2024 at 09:08:09PM +0300, Mike Rapoport wrote:
> +/* for /proc/kcore */
> +extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count);
> +
> +/*
> + *	Internals.  Don't use..
> + */
> +extern __init void vm_area_add_early(struct vm_struct *vm);
> +extern __init void vm_area_register_early(struct vm_struct *vm, size_t align);

Please drop the externs while you're at it. (one more down below)

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the linux-snps-arc mailing list