[PATCH] dt-bindings: pct: Convert to dtschema
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Mar 8 00:05:06 PST 2024
On 08/03/2024 03:18, Dorine Tipo wrote:
> convert the PCT Arc Performance Counter bindings to DT schema
There is no conversion here!
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo at gmail.com>
> ---
> .../devicetree/bindings/arc/pct.yaml | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arc/pct.yaml
>
> diff --git a/Documentation/devicetree/bindings/arc/pct.yaml b/Documentation/devicetree/bindings/arc/pct.yaml
> new file mode 100644
> index 000000000000..1f97a7c21b77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arc/pct.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pct.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARC Performance Counters
> +
> +maintainers:
> + - Vineet Gupta <vgupta at kernel.org>
> + - Rob Herring <robh+dt at kernel.org>
> + - Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
No, neither me nor Rob have anything to do with Arc. Please choose
someone from the ARC maintainers, if there is no specific device maintainer.
> +
> +description: |
> + The ARC700 can be configured with a pipeline performance monitor for counting
> + CPU and cache events like cache misses and hits. Like conventional PCT there
> + are 100+ hardware conditions dynamically mapped to up to 32 counters
> +
> +properties:
> + compatible:
> + const: "snps,arc700-pct"
Drop quotes. I have doubts that you tested it.
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
This must be additionalProperties instead. See example schema.
> +
> +examples:
> + - |
> + pmu {
> + compatible = "snps,arc700-pct";
NAK, test your patches.
>
Best regards,
Krzysztof
More information about the linux-snps-arc
mailing list