[PATCH mm-unstable 13/17] mm: sparc64: Introduce arch_mmap_hint()
kernel test robot
lkp at intel.com
Tue Dec 10 06:45:54 PST 2024
Hi Kalesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Kalesh-Singh/mm-Introduce-generic_mmap_hint/20241210-104424
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20241210024119.2488608-14-kaleshsingh%40google.com
patch subject: [PATCH mm-unstable 13/17] mm: sparc64: Introduce arch_mmap_hint()
config: sparc-randconfig-002-20241210 (https://download.01.org/0day-ci/archive/20241210/202412102215.fF34r4Uo-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241210/202412102215.fF34r4Uo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412102215.fF34r4Uo-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/sparc/kernel/sys_sparc_64.c: In function 'arch_get_unmapped_area':
>> arch/sparc/kernel/sys_sparc_64.c:135:13: warning: variable 'do_color_align' set but not used [-Wunused-but-set-variable]
135 | int do_color_align;
| ^~~~~~~~~~~~~~
vim +/do_color_align +135 arch/sparc/kernel/sys_sparc_64.c
aef9ae8eac4116 arch/sparc/kernel/sys_sparc_64.c Kalesh Singh 2024-12-09 131
25d4054cc97484 arch/sparc/kernel/sys_sparc_64.c Mark Brown 2024-09-04 132 unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags, vm_flags_t vm_flags)
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 133 {
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 134 unsigned long task_size = TASK_SIZE;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 @135 int do_color_align;
b80fa3cbb78c0f arch/sparc/kernel/sys_sparc_64.c Rick Edgecombe 2024-03-25 136 struct vm_unmapped_area_info info = {};
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 137 bool file_hugepage = false;
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 138
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 139 if (filp && is_file_hugepages(filp))
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 140 file_hugepage = true;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 141
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 142 if (flags & MAP_FIXED) {
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 143 /* We do not accept a shared mapping if it would violate
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 144 * cache aliasing constraints.
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 145 */
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 146 if (!file_hugepage && (flags & MAP_SHARED) &&
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 147 ((addr - (pgoff << PAGE_SHIFT)) & (SHMLBA - 1)))
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 148 return -EINVAL;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 149 return addr;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 150 }
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 151
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 152 if (test_thread_flag(TIF_32BIT))
d61e16df940e02 arch/sparc64/kernel/sys_sparc.c David S. Miller 2006-03-17 153 task_size = STACK_TOP32;
a91690ddd05ab0 arch/sparc64/kernel/sys_sparc.c David S. Miller 2006-03-17 154 if (unlikely(len > task_size || len >= VA_EXCLUDE_START))
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 155 return -ENOMEM;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 156
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 157 do_color_align = 0;
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 158 if ((filp || (flags & MAP_SHARED)) && !file_hugepage)
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 159 do_color_align = 1;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 160
aef9ae8eac4116 arch/sparc/kernel/sys_sparc_64.c Kalesh Singh 2024-12-09 161 addr = arch_mmap_hint(filp, addr, len, pgoff, flags);
aef9ae8eac4116 arch/sparc/kernel/sys_sparc_64.c Kalesh Singh 2024-12-09 162 if (addr)
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 163 return addr;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 164
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 165 info.length = len;
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 166 info.low_limit = TASK_UNMAPPED_BASE;
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 167 info.high_limit = min(task_size, VA_EXCLUDE_START);
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 168 info.align_mask = get_align_mask(filp, flags);
a8d457b29b017a arch/sparc/kernel/sys_sparc_64.c Oscar Salvador 2024-10-07 169 if (!file_hugepage)
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 170 info.align_offset = pgoff << PAGE_SHIFT;
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 171 addr = vm_unmapped_area(&info);
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 172
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 173 if ((addr & ~PAGE_MASK) && task_size > VA_EXCLUDE_END) {
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 174 VM_BUG_ON(addr != -ENOMEM);
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 175 info.low_limit = VA_EXCLUDE_END;
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 176 info.high_limit = task_size;
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 177 addr = vm_unmapped_area(&info);
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 178 }
1363c3cd8603a9 arch/sparc64/kernel/sys_sparc.c Wolfgang Wander 2005-06-21 179
bb64f55019c7b0 arch/sparc/kernel/sys_sparc_64.c Michel Lespinasse 2012-12-11 180 return addr;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 181 }
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c Linus Torvalds 2005-04-16 182
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-snps-arc
mailing list