[PATCH RFC 03/17] of: Use -ENODEV consistently in of_iommu_configure()
Rob Herring
robh at kernel.org
Wed Nov 8 08:11:38 PST 2023
On Fri, Nov 03, 2023 at 01:44:48PM -0300, Jason Gunthorpe wrote:
> Instead of returning 1 and trying to handle positive error codes just
> stick to the convention of returning -ENODEV. Remove references to ops
> from of_iommu_configure(), a NULL ops will already generate an error code.
nit: "iommu: of: ..." or "iommu/of: " for the subject. "of: ..." is
generally drivers/of/.
>
> There is no reason to check dev->bus, if err=0 at this point then the
> called configure functions thought there was an iommu and we should try to
> probe it. Remove it.
>
> Signed-off-by: Jason Gunthorpe <jgg at nvidia.com>
> ---
> drivers/iommu/of_iommu.c | 42 +++++++++++++---------------------------
> 1 file changed, 13 insertions(+), 29 deletions(-)
More information about the linux-snps-arc
mailing list