[PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP
Baoquan He
bhe at redhat.com
Tue May 30 02:25:01 PDT 2023
Hi Christoph,
On 05/16/23 at 11:31pm, Christoph Hellwig wrote:
> > +#define ioremap ioremap
> > +#define ioremap_prot ioremap_prot
> > +#define iounmap iounmap
>
> Nit: I think it's cleaner to have these #defines right next to the
> function declaration.
For this one, I didn't add function declaration of ioremap_prot and
iounmap in arch/arc/include/asm/io.h and the same to other arch's
asm/io.h. Because asm-generic/io.h already has those function
declaration, then ARCH's asm/io.h includeasm-generic/io.h. I tried
adding function declarations for ioremap_prot() and iounmap(), building
passed too. Do you think we need add extra function declarations in
ARCH's asm/io.h file?
Thanks
Baoquan
More information about the linux-snps-arc
mailing list