[PATCH] serial: arc_uart: Drop empty platform remove function

Ilpo Järvinen ilpo.jarvinen at linux.intel.com
Tue Dec 13 02:26:33 PST 2022


On Mon, 12 Dec 2022, Uwe Kleine-König wrote:

> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen at linux.intel.com>

-- 
 i.

> ---
>  drivers/tty/serial/arc_uart.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 2a65ea2660e1..f1b6034addda 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -632,12 +632,6 @@ static int arc_serial_probe(struct platform_device *pdev)
>  	return uart_add_one_port(&arc_uart_driver, &arc_uart_ports[dev_id].port);
>  }
>  
> -static int arc_serial_remove(struct platform_device *pdev)
> -{
> -	/* This will never be called */
> -	return 0;
> -}
> -
>  static const struct of_device_id arc_uart_dt_ids[] = {
>  	{ .compatible = "snps,arc-uart" },
>  	{ /* Sentinel */ }
> @@ -646,7 +640,6 @@ MODULE_DEVICE_TABLE(of, arc_uart_dt_ids);
>  
>  static struct platform_driver arc_platform_driver = {
>  	.probe = arc_serial_probe,
> -	.remove = arc_serial_remove,
>  	.driver = {
>  		.name = DRIVER_NAME,
>  		.of_match_table  = arc_uart_dt_ids,
> 


More information about the linux-snps-arc mailing list