[PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate DWC3 sub-node

[Wan Mohamad, Wan Ahmad Zainie]

Hi Serge.

> -----Original Message-----
> From: Serge Semin <Sergey.Semin at baikalelectronics.ru>
> Sent: Saturday, December 5, 2020 11:24 PM
> To: Nyman, Mathias <mathias.nyman at intel.com>; Felipe Balbi
> <balbi at kernel.org>; Krzysztof Kozlowski <krzk at kernel.org>; Greg Kroah-
> Hartman <gregkh at linuxfoundation.org>; Rob Herring
> <robh+dt at kernel.org>; Chunfeng Yun <chunfeng.yun at mediatek.com>;
> Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad at intel.com>
> Cc: Serge Semin <Sergey.Semin at baikalelectronics.ru>; Serge Semin
> <fancer.lancer at gmail.com>; Alexey Malahov
> <Alexey.Malahov at baikalelectronics.ru>; Pavel Parkhomenko
> <Pavel.Parkhomenko at baikalelectronics.ru>; Andy Gross
> <agross at kernel.org>; Bjorn Andersson <bjorn.andersson at linaro.org>;
> Manu Gautam <mgautam at codeaurora.org>; Roger Quadros
> <rogerq at ti.com>; Lad Prabhakar <prabhakar.mahadev-
> lad.rj at bp.renesas.com>; Yoshihiro Shimoda
> <yoshihiro.shimoda.uh at renesas.com>; narmstrong
> <narmstrong at baylibre.com>; Kevin Hilman <khilman at baylibre.com>;
> Martin Blumenstingl <martin.blumenstingl at googlemail.com>; linux-arm-
> kernel at lists.infradead.org; linux-snps-arc at lists.infradead.org; linux-
> mips at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; linux-
> usb at vger.kernel.org; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate
> DWC3 sub-node
> 
> Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC
> USB3 compatible sub-node to describe a fully functioning USB interface. Let's
> use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub-
> nodes.
> 
> Note since the generic DWC USB3 DT node is supposed to be named as
> generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-
> nodes name regexp and fix the DT node example.
> 
> Signed-off-by: Serge Semin <Sergey.Semin at baikalelectronics.ru>

LGTM. With minor change to fix the typo above, Qualcomm to Intel
Keem Bay,
Acked-by: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad at intel.com>

> 
> ---
> 
> Changelog v5:
> - This is a new patch created for the new Intel Keem Bay bindings file,
>   which has been added just recently.
> ---
>  .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-
> dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-
> dwc3.yaml
> index dd32c10ce6c7..43b91ab62004 100644
> --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
> @@ -34,11 +34,8 @@ properties:
>  # Required child node:
> 
>  patternProperties:
> -  "^dwc3@[0-9a-f]+$":
> -    type: object
> -    description:
> -      A child node must exist to represent the core DWC3 IP block.
> -      The content of the node is defined in dwc3.txt.
> +  "^usb@[0-9a-f]+$":
> +    $ref: snps,dwc3.yaml#
> 
>  required:
>    - compatible
> @@ -68,7 +65,7 @@ examples:
>            #address-cells = <1>;
>            #size-cells = <1>;
> 
> -          dwc3 at 34000000 {
> +          usb at 34000000 {
>                  compatible = "snps,dwc3";
>                  reg = <0x34000000 0x10000>;
>                  interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.29.2

Best regards,
Zainie