[PATCH] arc: remove num-slots from arc platforms

Shawn Lin shawn.lin at rock-chips.com
Thu Jul 6 04:46:55 PDT 2017


Hi Alexey,

On 2017/7/6 19:33, Alexey Brodkin wrote:
> Hi Jaehoon,
> 
> On Thu, 2017-07-06 at 13:17 +0900, Jaehoon Chung wrote:
>> On 07/05/
>> Right, that's why doesn't use the multiple slot.
>> Company hopes to make the product that costumer is satisfied.
>> Performance is one of important things...
>> For saving about the cost that using more IP ...use the multiple slots via one IP?
>> It doesn't make sense..but i don't know why your board is using the multiple slot..
>> Maybe there are some reasons..?
> 
> Indeed there is. As it was quite late decision so we thought why not to use
> this nice feature and serve yet another SDIO device for free with just addition of
> a couple of wires (compare it with another controller integration in a SoC).
> 
>>> Anyways we still don't have that SDIO peripheral working as expected
>>> and for now only 1 slot is fine. Though it might become a nightmare for me
>>> if the need for the second slot really arises. But let's see how it goes.
>>>
>>> BTW do you know if that multi-slot functionality was ever tested at all?
>>
>> I know...i didn't never test the multi-slot..did you check the slot->sdio_id?
> 
> Well I think to some extent it worked for me but for some reason attached peripheral
> was not answering to any command so there could be another problem not related to DW MMC
> controller. Again as I understood slot is selected simply by supplying a clock.
> I.e. data is put on the same lines for all attached SD-devices and who gets a clock from
> the controller becomes active.
> 
> We'll see if I get this peripheral working then probably I'll need to revisit that
> slot-related topic.
> 
>> Rockchip is using the slot 8 as sdio peripheral.
> 
> Still slot support is getting dropped? :)
> Like Rockchip people don't care?

As we hard-code the slot number for sdio peripheral and won't change
anymore, so we actually don't object killing slot concept.

And we haven't come up with any use case for multi-slot for the past
years for any rockchip platforms, but instead we have to carefully carry
on the code to check the slot which makes the code hard to be improved.

> 
>> As you already know, dwmmc needs to shift the bit according to slot.
> 
> Yeah, I saw that.
> 
> -Alexey
> 




More information about the linux-snps-arc mailing list