[PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall

Colin King colin.king at canonical.com
Mon Oct 24 03:47:14 PDT 2016


From: Colin Ian King <colin.king at canonical.com>

arc_usr_cmpxchg currently returns an uninitialized value in ret
on a failed access_ok call. Instead, return -EFAULT.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 arch/arc/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c
index a746008..9ae3e1c 100644
--- a/arch/arc/kernel/process.c
+++ b/arch/arc/kernel/process.c
@@ -47,7 +47,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new)
 	int ret;
 
 	if (!access_ok(VERIFY_WRITE, uaddr, sizeof(int)))
-		return ret;
+		return -EFAULT;
 
 	preempt_disable();
 
-- 
2.9.3




More information about the linux-snps-arc mailing list