[PATCH v1 02/20] clocksource: Add NPS400 timers driver

Noam Camus noamc at ezchip.com
Tue Nov 3 07:18:15 PST 2015


From: Vineet Gupta [mailto:Vineet.Gupta1 at synopsys.com] 
Sent: Monday, November 02, 2015 1:04 PM

>> +
>> +	upper = ioread32be(upper_p);

>Consider using the _relaxed macros even if your platform doesn't have specific IO barriers.
[Noam Camus] What is the big endian flavor for _relaxed macros.
 
>> +	counter = upper;
>> +	counter <<= 32;
>> +	counter |= lower;

>It is easier to read:

>counter = (upper << 32) | lower;

Thanks I will update

- Noam




More information about the linux-snps-arc mailing list