[PATCH v1 02/20] clocksource: Add NPS400 timers driver

Noam Camus noamc at ezchip.com
Sun Nov 1 23:57:43 PST 2015


> From: Daniel Lezcano [mailto:daniel.lezcano at linaro.org] 
> Sent: Sunday, November 01, 2015 10:44 PM

> Please add an entry in the clocksource's Kconfig.

> eg:
OK

> Are you sure all the headers are needed ?
Thanks, will revise this part.

> Why do you need to disable the interrupt here ?
Thanks, seem like left over from past issue, I will remove.


> May be you can consider using only the 32bits. Sometimes it is faster than using 64bits arithmetic and reading the register three times.

> https://lkml.org/lkml/2014/6/20/431
Our device can reach 1000MHz.
That means that the 32-bit half of the counter rolls over every ~4 seconds.
I am not sure optimization is justified.

-Noam



More information about the linux-snps-arc mailing list