[PATCH] staging: vc04_services: vchiq_bus: Check return value of of_dma_configure()

Dan Carpenter dan.carpenter at linaro.org
Tue Dec 2 02:18:10 PST 2025


You're not working against the latest tree so this doesn't apply.

On Tue, Dec 02, 2025 at 05:52:52PM +0800, Haotian Zhang wrote:
> vchiq_device_register() ignores the return value of of_dma_configure(),
> which may return -EPROBE_DEFER when the IOMMU is not ready or other error
> codes. This allows device registration to proceed with incomplete DMA
> configuration.
> 

If of_dma_configure() returns -EPROBE_DEFER then this will just fail and
that's not really any better than the existing behavior...

regards,
dan carpenter

> Check of_dma_configure() return value and fail device registration
> on error.
> 
> Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type")
> Signed-off-by: Haotian Zhang <vulab at iscas.ac.cn>




More information about the linux-rpi-kernel mailing list