[PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()

Scott Branden scott.branden at broadcom.com
Wed Jun 9 08:57:44 PDT 2021


On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> 在 2021/6/1 16:28, Zhihao Cheng 写道:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <hulkci at huawei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
Acked-by: Scott Branden <scott.branden at broadcom.com>
>> ---
>>   drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
>> index b4f33dc399a0..78073ad1f2f1 100644
>> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
>> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
>> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>>       mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>>       if (IS_ERR(mbox->regs)) {
>>           ret = PTR_ERR(mbox->regs);
>> -        dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>>           goto fail;
>>       }
>>       regs_end = mbox->regs + resource_size(iomem);
> 
> friendly ping.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4212 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20210609/da82f543/attachment.p7s>


More information about the linux-rpi-kernel mailing list