From chengzhihao1 at huawei.com  Tue Jun  1 01:24:54 2021
From: chengzhihao1 at huawei.com (Zhihao Cheng)
Date: Tue, 1 Jun 2021 16:24:54 +0800
Subject: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in
 bcm2835_mbox_probe()
Message-ID: <20210601082454.127810-1-chengzhihao1@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
---
 drivers/mailbox/bcm2835-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
index 39761d190545..86b7ce3549c5 100644
--- a/drivers/mailbox/bcm2835-mailbox.c
+++ b/drivers/mailbox/bcm2835-mailbox.c
@@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
 	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
 	if (IS_ERR(mbox->regs)) {
 		ret = PTR_ERR(mbox->regs);
-		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
 		return ret;
 	}
 
-- 
2.31.1



From chengzhihao1 at huawei.com  Tue Jun  1 01:28:34 2021
From: chengzhihao1 at huawei.com (Zhihao Cheng)
Date: Tue, 1 Jun 2021 16:28:34 +0800
Subject: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in
 flexrm_mbox_probe()
Message-ID: <20210601082834.129587-1-chengzhihao1@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
---
 drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index b4f33dc399a0..78073ad1f2f1 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
 	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
 	if (IS_ERR(mbox->regs)) {
 		ret = PTR_ERR(mbox->regs);
-		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
 		goto fail;
 	}
 	regs_end = mbox->regs + resource_size(iomem);
-- 
2.31.1



From nsaenzju at redhat.com  Tue Jun  8 03:05:43 2021
From: nsaenzju at redhat.com (Nicolas Saenz Julienne)
Date: Tue,  8 Jun 2021 12:05:43 +0200
Subject: [GIT PULL 1/1] bcm2835-dt-next-2021-06-08
Message-ID: <20210608100543.691185-1-nsaenzju@redhat.com>

Hi Florian,

The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:

  Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08

for you to fetch changes up to ca5909b7fa6af9c7b9a215a8708926e44345a220:

  arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 10:44:36 +0200)

----------------------------------------------------------------

- Fixup MMC node names
- Fixup led node names
- Introduce new devicetree file for Raspberry Pi 400
- Fix issue with dwc2's FIFO's size
- Add VEC compatible for bcm2711

----------------------------------------------------------------
Mateusz Kwiatkowski (1):
      ARM: boot: dts: bcm2711: Add BCM2711 VEC compatible

Stefan Wahren (6):
      Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
      ARM: dts: bcm283x: Fix up MMC node names
      ARM: dts: Move BCM2711 RPi specific into separate dtsi
      ARM: dts: bcm283x: Fix up GPIO LED node names
      ARM: dts: Add Raspberry Pi 400 support
      arm64: dts: broadcom: Add reference to RPi 400

 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts             | 85 ++++-------------------
 arch/arm/boot/dts/bcm2711-rpi-400.dts             | 45 ++++++++++++
 arch/arm/boot/dts/bcm2711-rpi.dtsi                | 74 ++++++++++++++++++++
 arch/arm/boot/dts/bcm2711.dtsi                    |  3 +-
 arch/arm/boot/dts/bcm2835-rpi-a-plus.dts          |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-a.dts               |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-b-plus.dts          |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts          |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-b.dts               |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-cm1.dtsi            |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts          |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-zero.dts            |  2 +-
 arch/arm/boot/dts/bcm2835-rpi.dtsi                |  2 +-
 arch/arm/boot/dts/bcm2836-rpi-2-b.dts             |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts        |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts        |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts             |  2 +-
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi            |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi        |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi |  2 +-
 arch/arm/boot/dts/bcm283x.dtsi                    |  2 +-
 arch/arm64/boot/dts/broadcom/Makefile             |  3 +-
 arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts  |  2 +
 24 files changed, 160 insertions(+), 97 deletions(-)
 create mode 100644 arch/arm/boot/dts/bcm2711-rpi-400.dts
 create mode 100644 arch/arm/boot/dts/bcm2711-rpi.dtsi
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts



From info at gammashift.ca  Tue Jun  8 05:40:32 2021
From: info at gammashift.ca (Lonnie Ray)
Date: 08 Jun 2021 15:40:32 +0300
Subject: Inquiry for New Order
Message-ID: <20210608154032.7F2DEBDDA22C70DE@gammashift.ca>

Good Morning

We are making inquiry about your product, Please send us a 
catalogue of your products to enable us prepare an official 
Purchase Order.
Our shipping terms is CIF Nashvill, So Please quote your best 
possible prices CIF Nashvill.

Awaiting your urgent reply

Have a great day and thanks again.

Best Regards,


Lonnie Ray
Southern Carlson
635 Fairgrounds Road
Muscle Shoals, AL 35661, USA
Phone number : +1-256-248-2020


From f.fainelli at gmail.com  Tue Jun  8 07:21:56 2021
From: f.fainelli at gmail.com (Florian Fainelli)
Date: Tue, 8 Jun 2021 07:21:56 -0700
Subject: [GIT PULL 1/1] bcm2835-dt-next-2021-06-08
In-Reply-To: <20210608100543.691185-1-nsaenzju@redhat.com>
References: <20210608100543.691185-1-nsaenzju@redhat.com>
Message-ID: <4f3bf1bb-1544-85f4-0539-033f36f86d19@gmail.com>

Hi Nicolas,

On 6/8/2021 3:05 AM, Nicolas Saenz Julienne wrote:
> Hi Florian,
> 
> The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
> 
>   Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08
> 
> for you to fetch changes up to ca5909b7fa6af9c7b9a215a8708926e44345a220:
> 
>   arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 10:44:36 +0200)
> 
> ----------------------------------------------------------------

How about:

https://lore.kernel.org/linux-arm-kernel/1622981777-5023-5-git-send-email-stefan.wahren at i2se.com/

can you add this to this pull request?

> 
> - Fixup MMC node names
> - Fixup led node names
> - Introduce new devicetree file for Raspberry Pi 400
> - Fix issue with dwc2's FIFO's size
> - Add VEC compatible for bcm2711
> 
> ----------------------------------------------------------------
> Mateusz Kwiatkowski (1):
>       ARM: boot: dts: bcm2711: Add BCM2711 VEC compatible
> 
> Stefan Wahren (6):
>       Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
>       ARM: dts: bcm283x: Fix up MMC node names
>       ARM: dts: Move BCM2711 RPi specific into separate dtsi
>       ARM: dts: bcm283x: Fix up GPIO LED node names
>       ARM: dts: Add Raspberry Pi 400 support
>       arm64: dts: broadcom: Add reference to RPi 400
> 
>  arch/arm/boot/dts/Makefile                        |  1 +
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts             | 85 ++++-------------------
>  arch/arm/boot/dts/bcm2711-rpi-400.dts             | 45 ++++++++++++
>  arch/arm/boot/dts/bcm2711-rpi.dtsi                | 74 ++++++++++++++++++++
>  arch/arm/boot/dts/bcm2711.dtsi                    |  3 +-
>  arch/arm/boot/dts/bcm2835-rpi-a-plus.dts          |  4 +-
>  arch/arm/boot/dts/bcm2835-rpi-a.dts               |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi-b-plus.dts          |  4 +-
>  arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts          |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi-b.dts               |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi-cm1.dtsi            |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi-zero-w.dts          |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi-zero.dts            |  2 +-
>  arch/arm/boot/dts/bcm2835-rpi.dtsi                |  2 +-
>  arch/arm/boot/dts/bcm2836-rpi-2-b.dts             |  4 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts        |  4 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts        |  4 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-b.dts             |  2 +-
>  arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi            |  2 +-
>  arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi        |  2 +-
>  arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi |  2 +-
>  arch/arm/boot/dts/bcm283x.dtsi                    |  2 +-
>  arch/arm64/boot/dts/broadcom/Makefile             |  3 +-
>  arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts  |  2 +
>  24 files changed, 160 insertions(+), 97 deletions(-)
>  create mode 100644 arch/arm/boot/dts/bcm2711-rpi-400.dts
>  create mode 100644 arch/arm/boot/dts/bcm2711-rpi.dtsi
>  create mode 100644 arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts
> 

-- 
Florian


From nsaenzju at redhat.com  Tue Jun  8 11:33:53 2021
From: nsaenzju at redhat.com (Nicolas Saenz Julienne)
Date: Tue, 08 Jun 2021 20:33:53 +0200
Subject: [GIT PULL 1/1] bcm2835-dt-next-2021-06-08
In-Reply-To: <4f3bf1bb-1544-85f4-0539-033f36f86d19@gmail.com>
References: <20210608100543.691185-1-nsaenzju@redhat.com>
 <4f3bf1bb-1544-85f4-0539-033f36f86d19@gmail.com>
Message-ID: <e032ee6b46097ded860e680e913827d0a3a1938b.camel@redhat.com>

On Tue, 2021-06-08 at 07:21 -0700, Florian Fainelli wrote:
> Hi Nicolas,
> 
> On 6/8/2021 3:05 AM, Nicolas Saenz Julienne wrote:
> > Hi Florian,
> > 
> > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
> > 
> > ??Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
> > 
> > are available in the Git repository at:
> > 
> > ??https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08
> > 
> > for you to fetch changes up to ca5909b7fa6af9c7b9a215a8708926e44345a220:
> > 
> > ??arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 10:44:36 +0200)
> > 
> > ----------------------------------------------------------------
> 
> How about:
> 
> https://lore.kernel.org/linux-arm-kernel/1622981777-5023-5-git-send-email-stefan.wahren at i2se.com/
> 
> can you add this to this pull request?

Sure, I figured that since it's a DT binding it should go through RobH's tree.

Regards,
Nicolas



From f.fainelli at gmail.com  Tue Jun  8 12:48:34 2021
From: f.fainelli at gmail.com (Florian Fainelli)
Date: Tue, 8 Jun 2021 12:48:34 -0700
Subject: [GIT PULL 1/1] bcm2835-dt-next-2021-06-08
In-Reply-To: <e032ee6b46097ded860e680e913827d0a3a1938b.camel@redhat.com>
References: <20210608100543.691185-1-nsaenzju@redhat.com>
 <4f3bf1bb-1544-85f4-0539-033f36f86d19@gmail.com>
 <e032ee6b46097ded860e680e913827d0a3a1938b.camel@redhat.com>
Message-ID: <f60d1679-51d8-c6d3-9793-4d5e08ee6f71@gmail.com>



On 6/8/2021 11:33 AM, Nicolas Saenz Julienne wrote:
> On Tue, 2021-06-08 at 07:21 -0700, Florian Fainelli wrote:
>> Hi Nicolas,
>>
>> On 6/8/2021 3:05 AM, Nicolas Saenz Julienne wrote:
>>> Hi Florian,
>>>
>>> The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
>>>
>>> ??Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
>>>
>>> are available in the Git repository at:
>>>
>>> ??https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08
>>>
>>> for you to fetch changes up to ca5909b7fa6af9c7b9a215a8708926e44345a220:
>>>
>>> ??arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 10:44:36 +0200)
>>>
>>> ----------------------------------------------------------------
>>
>> How about:
>>
>> https://lore.kernel.org/linux-arm-kernel/1622981777-5023-5-git-send-email-stefan.wahren at i2se.com/
>>
>> can you add this to this pull request?
> 
> Sure, I figured that since it's a DT binding it should go through RobH's tree.

Since RobH acked it this seems to communicate that other subsystem
maintainers that they can take the patch via their tree. Thanks for
issuing a v2.
-- 
Florian


From nsaenzju at redhat.com  Tue Jun  8 14:10:12 2021
From: nsaenzju at redhat.com (Nicolas Saenz Julienne)
Date: Tue,  8 Jun 2021 23:10:12 +0200
Subject: [GIT PULL v2 1/1] bcm2835-dt-next-2021-06-08-v2
Message-ID: <20210608211012.1386151-1-nsaenzju@redhat.com>

Hi Florian,

The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:

  Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08-v2

for you to fetch changes up to 21c6bf8304f0141af6460cfe404dbbdeb96bdd62:

  arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 23:06:34 +0200)

----------------------------------------------------------------

- Fixup MMC node names
- Fixup led node names
- Introduce new devicetree file for Raspberry Pi 400
- Introduce devicetree bindings for Raspberry Pi 400
- Fix issue with dwc2's FIFO's size
- Add VEC compatible for bcm2711

----------------------------------------------------------------
Mateusz Kwiatkowski (1):
      ARM: boot: dts: bcm2711: Add BCM2711 VEC compatible

Stefan Wahren (7):
      Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
      ARM: dts: bcm283x: Fix up MMC node names
      ARM: dts: Move BCM2711 RPi specific into separate dtsi
      dt-bindings: arm: bcm2835: Add Raspberry Pi 400 to DT schema
      ARM: dts: bcm283x: Fix up GPIO LED node names
      ARM: dts: Add Raspberry Pi 400 support
      arm64: dts: broadcom: Add reference to RPi 400

 .../devicetree/bindings/arm/bcm/bcm2835.yaml       |  1 +
 arch/arm/boot/dts/Makefile                         |  1 +
 arch/arm/boot/dts/bcm2711-rpi-4-b.dts              | 85 +++-------------------
 arch/arm/boot/dts/bcm2711-rpi-400.dts              | 45 ++++++++++++
 arch/arm/boot/dts/bcm2711-rpi.dtsi                 | 74 +++++++++++++++++++
 arch/arm/boot/dts/bcm2711.dtsi                     |  3 +-
 arch/arm/boot/dts/bcm2835-rpi-a-plus.dts           |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-a.dts                |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-b-plus.dts           |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts           |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-b.dts                |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-cm1.dtsi             |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts           |  2 +-
 arch/arm/boot/dts/bcm2835-rpi-zero.dts             |  2 +-
 arch/arm/boot/dts/bcm2835-rpi.dtsi                 |  2 +-
 arch/arm/boot/dts/bcm2836-rpi-2-b.dts              |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts         |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts         |  4 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts              |  2 +-
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi             |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi         |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi  |  2 +-
 arch/arm/boot/dts/bcm283x.dtsi                     |  2 +-
 arch/arm64/boot/dts/broadcom/Makefile              |  3 +-
 arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts   |  2 +
 25 files changed, 161 insertions(+), 97 deletions(-)
 create mode 100644 arch/arm/boot/dts/bcm2711-rpi-400.dts
 create mode 100644 arch/arm/boot/dts/bcm2711-rpi.dtsi
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dts



From chengzhihao1 at huawei.com  Wed Jun  9 05:13:07 2021
From: chengzhihao1 at huawei.com (Zhihao Cheng)
Date: Wed, 9 Jun 2021 20:13:07 +0800
Subject: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in
 bcm2835_mbox_probe()
In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com>
References: <20210601082454.127810-1-chengzhihao1@huawei.com>
Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com>

? 2021/6/1 16:24, Zhihao Cheng ??:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
> ---
>   drivers/mailbox/bcm2835-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
> index 39761d190545..86b7ce3549c5 100644
> --- a/drivers/mailbox/bcm2835-mailbox.c
> +++ b/drivers/mailbox/bcm2835-mailbox.c
> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		return ret;
>   	}
>   

friendly ping.



From chengzhihao1 at huawei.com  Wed Jun  9 05:13:35 2021
From: chengzhihao1 at huawei.com (Zhihao Cheng)
Date: Wed, 9 Jun 2021 20:13:35 +0800
Subject: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err
 call in flexrm_mbox_probe()
In-Reply-To: <20210601082834.129587-1-chengzhihao1@huawei.com>
References: <20210601082834.129587-1-chengzhihao1@huawei.com>
Message-ID: <cfa3162b-32eb-487a-d01e-6d69293c9965@huawei.com>

? 2021/6/1 16:28, Zhihao Cheng ??:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
> ---
>   drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index b4f33dc399a0..78073ad1f2f1 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		goto fail;
>   	}
>   	regs_end = mbox->regs + resource_size(iomem);

friendly ping.



From scott.branden at broadcom.com  Wed Jun  9 08:57:44 2021
From: scott.branden at broadcom.com (Scott Branden)
Date: Wed, 9 Jun 2021 08:57:44 -0700
Subject: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err
 call in flexrm_mbox_probe()
In-Reply-To: <cfa3162b-32eb-487a-d01e-6d69293c9965@huawei.com>
References: <20210601082834.129587-1-chengzhihao1@huawei.com>
 <cfa3162b-32eb-487a-d01e-6d69293c9965@huawei.com>
Message-ID: <e046f8fd-93ef-89da-3d60-96854c229d67@broadcom.com>

On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> ? 2021/6/1 16:28, Zhihao Cheng ??:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <hulkci at huawei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
Acked-by: Scott Branden <scott.branden at broadcom.com>
>> ---
>> ? drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>> ? 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
>> index b4f33dc399a0..78073ad1f2f1 100644
>> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
>> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
>> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>> ????? mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>> ????? if (IS_ERR(mbox->regs)) {
>> ????????? ret = PTR_ERR(mbox->regs);
>> -??????? dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>> ????????? goto fail;
>> ????? }
>> ????? regs_end = mbox->regs + resource_size(iomem);
> 
> friendly ping.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4212 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20210609/da82f543/attachment.p7s>

From scott.branden at broadcom.com  Wed Jun  9 08:58:11 2021
From: scott.branden at broadcom.com (Scott Branden)
Date: Wed, 9 Jun 2021 08:58:11 -0700
Subject: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in
 bcm2835_mbox_probe()
In-Reply-To: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com>
References: <20210601082454.127810-1-chengzhihao1@huawei.com>
 <226660de-e502-68b8-131d-27552ccccfd0@huawei.com>
Message-ID: <ca893045-7325-d089-c4b2-5d089a0a0bd8@broadcom.com>

On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> ? 2021/6/1 16:24, Zhihao Cheng ??:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <hulkci at huawei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
Acked-by: Scott Branden <scott.branden at broadcom.com>
>> ---
>> ? drivers/mailbox/bcm2835-mailbox.c | 1 -
>> ? 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
>> index 39761d190545..86b7ce3549c5 100644
>> --- a/drivers/mailbox/bcm2835-mailbox.c
>> +++ b/drivers/mailbox/bcm2835-mailbox.c
>> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>> ????? mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>> ????? if (IS_ERR(mbox->regs)) {
>> ????????? ret = PTR_ERR(mbox->regs);
>> -??????? dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>> ????????? return ret;
>> ????? }
>> ? 
> 
> friendly ping.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4212 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20210609/0df7d62e/attachment.p7s>

From f.fainelli at gmail.com  Wed Jun  9 12:05:12 2021
From: f.fainelli at gmail.com (Florian Fainelli)
Date: Wed, 9 Jun 2021 12:05:12 -0700
Subject: [GIT PULL v2 1/1] bcm2835-dt-next-2021-06-08-v2
In-Reply-To: <20210608211012.1386151-1-nsaenzju@redhat.com>
References: <20210608211012.1386151-1-nsaenzju@redhat.com>
Message-ID: <1d894fb1-16d2-b695-862f-3f30ab186f3a@gmail.com>



On 6/8/2021 2:10 PM, Nicolas Saenz Julienne wrote:
> Hi Florian,
> 
> The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
> 
>   Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git tags/bcm2835-dt-next-2021-06-08-v2
> 
> for you to fetch changes up to 21c6bf8304f0141af6460cfe404dbbdeb96bdd62:
> 
>   arm64: dts: broadcom: Add reference to RPi 400 (2021-06-08 23:06:34 +0200)
> 
> ----------------------------------------------------------------

Merged into devicetree/next, thanks Nicolas!
-- 
Florian


From jhp at endlessos.org  Mon Jun 21 03:33:11 2021
From: jhp at endlessos.org (Jian-Hong Pan)
Date: Mon, 21 Jun 2021 18:33:11 +0800
Subject: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
Message-ID: <20210621103310.186334-1-jhp@endlessos.org>

The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
PHY.

bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
...
could not attach to PHY
bcmgenet fd580000.ethernet eth0: failed to connect to PHY
uart-pl011 fe201000.serial: no DMA platform data
libphy: bcmgenet MII bus: probed
...
unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus

This patch makes GENET try to connect the PHY up to 3 times. Also, waits
a while between each time for mdio-bcm-unimac module's loading and
probing.

Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=213485
Signed-off-by: Jian-Hong Pan <jhp at endlessos.org>
---
 drivers/net/ethernet/broadcom/genet/bcmmii.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 5335244e4577..64f244471fd3 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -289,6 +289,7 @@ int bcmgenet_mii_probe(struct net_device *dev)
 	struct phy_device *phydev;
 	u32 phy_flags = 0;
 	int ret;
+	int i;
 
 	/* Communicate the integrated PHY revision */
 	if (priv->internal_phy)
@@ -301,8 +302,22 @@ int bcmgenet_mii_probe(struct net_device *dev)
 	priv->old_pause = -1;
 
 	if (dn) {
-		phydev = of_phy_connect(dev, priv->phy_dn, bcmgenet_mii_setup,
-					phy_flags, priv->phy_interface);
+		/* Try to connect the PHY on UniMAC DMIO bus up to 3 times.
+		 * Wait a while between each time for mdio-bcm-unimac module's
+		 * loading and probing.
+		 */
+		phydev = NULL;
+		for (i = 1; i < 4 && !phydev; i++) {
+			netdev_info(dev,
+				    "connect %s on UniMAC MDIO bus %d time",
+				    priv->phy_dn->full_name, i);
+			phydev = of_phy_connect(dev, priv->phy_dn,
+						bcmgenet_mii_setup,
+						phy_flags, priv->phy_interface);
+			if (!phydev && i < 3)
+				msleep(500);
+		}
+
 		if (!phydev) {
 			pr_err("could not attach to PHY\n");
 			return -ENODEV;
-- 
2.32.0



From andrew at lunn.ch  Mon Jun 21 06:09:06 2021
From: andrew at lunn.ch (Andrew Lunn)
Date: Mon, 21 Jun 2021 15:09:06 +0200
Subject: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
In-Reply-To: <20210621103310.186334-1-jhp@endlessos.org>
References: <20210621103310.186334-1-jhp@endlessos.org>
Message-ID: <YNCPcmEPuwdwoLto@lunn.ch>

On Mon, Jun 21, 2021 at 06:33:11PM +0800, Jian-Hong Pan wrote:
> The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
> ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
> PHY.
> 
> bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
> ...
> could not attach to PHY
> bcmgenet fd580000.ethernet eth0: failed to connect to PHY
> uart-pl011 fe201000.serial: no DMA platform data
> libphy: bcmgenet MII bus: probed
> ...
> unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
> 
> This patch makes GENET try to connect the PHY up to 3 times. Also, waits
> a while between each time for mdio-bcm-unimac module's loading and
> probing.

Don't loop. Return -EPROBE_DEFER. The driver core will then probed the
driver again later, by which time, the MDIO bus driver should of
probed.

	Andrew


From f.fainelli at gmail.com  Mon Jun 21 09:37:10 2021
From: f.fainelli at gmail.com (Florian Fainelli)
Date: Mon, 21 Jun 2021 09:37:10 -0700
Subject: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
In-Reply-To: <YNCPcmEPuwdwoLto@lunn.ch>
References: <20210621103310.186334-1-jhp@endlessos.org>
 <YNCPcmEPuwdwoLto@lunn.ch>
Message-ID: <35f4baae-a6e1-c87d-279c-74f8c18bb5d1@gmail.com>

On 6/21/21 6:09 AM, Andrew Lunn wrote:
> On Mon, Jun 21, 2021 at 06:33:11PM +0800, Jian-Hong Pan wrote:
>> The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
>> ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
>> PHY.
>>
>> bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
>> ...
>> could not attach to PHY
>> bcmgenet fd580000.ethernet eth0: failed to connect to PHY
>> uart-pl011 fe201000.serial: no DMA platform data
>> libphy: bcmgenet MII bus: probed
>> ...
>> unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
>>
>> This patch makes GENET try to connect the PHY up to 3 times. Also, waits
>> a while between each time for mdio-bcm-unimac module's loading and
>> probing.
> 
> Don't loop. Return -EPROBE_DEFER. The driver core will then probed the
> driver again later, by which time, the MDIO bus driver should of
> probed.

This is unlikely to work because GENET register the mdio-bcm-unimac
platform device so we will likely run into a chicken and egg problem,
though surprisingly I have not seen this on STB platforms where GENET is
used, I will try building everything as a module like you do. Can you
see if the following helps:

diff --git a/drivers/net/mdio/mdio-bcm-unimac.c
b/drivers/net/mdio/mdio-bcm-unimac.c
index bfc9be23c973..d1844ef3724a 100644
--- a/drivers/net/mdio/mdio-bcm-unimac.c
+++ b/drivers/net/mdio/mdio-bcm-unimac.c
@@ -351,6 +351,7 @@ static struct platform_driver unimac_mdio_driver = {
                .pm = &unimac_mdio_pm_ops,
        },
        .probe  = unimac_mdio_probe,
+       .probe_type = PROBE_FORCE_SYNCHRONOUS,
        .remove = unimac_mdio_remove,
 };
 module_platform_driver(unimac_mdio_driver);
-- 
Florian


From f.fainelli at gmail.com  Mon Jun 21 09:47:21 2021
From: f.fainelli at gmail.com (Florian Fainelli)
Date: Mon, 21 Jun 2021 09:47:21 -0700
Subject: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
In-Reply-To: <35f4baae-a6e1-c87d-279c-74f8c18bb5d1@gmail.com>
References: <20210621103310.186334-1-jhp@endlessos.org>
 <YNCPcmEPuwdwoLto@lunn.ch> <35f4baae-a6e1-c87d-279c-74f8c18bb5d1@gmail.com>
Message-ID: <0f0b2647-ba50-a247-3b6e-aed1e1c77f67@gmail.com>

On 6/21/21 9:37 AM, Florian Fainelli wrote:
> On 6/21/21 6:09 AM, Andrew Lunn wrote:
>> On Mon, Jun 21, 2021 at 06:33:11PM +0800, Jian-Hong Pan wrote:
>>> The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
>>> ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
>>> PHY.
>>>
>>> bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
>>> ...
>>> could not attach to PHY
>>> bcmgenet fd580000.ethernet eth0: failed to connect to PHY
>>> uart-pl011 fe201000.serial: no DMA platform data
>>> libphy: bcmgenet MII bus: probed
>>> ...
>>> unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
>>>
>>> This patch makes GENET try to connect the PHY up to 3 times. Also, waits
>>> a while between each time for mdio-bcm-unimac module's loading and
>>> probing.
>>
>> Don't loop. Return -EPROBE_DEFER. The driver core will then probed the
>> driver again later, by which time, the MDIO bus driver should of
>> probed.
> 
> This is unlikely to work because GENET register the mdio-bcm-unimac
> platform device so we will likely run into a chicken and egg problem,
> though surprisingly I have not seen this on STB platforms where GENET is
> used, I will try building everything as a module like you do. Can you
> see if the following helps:
> 
> diff --git a/drivers/net/mdio/mdio-bcm-unimac.c
> b/drivers/net/mdio/mdio-bcm-unimac.c
> index bfc9be23c973..d1844ef3724a 100644
> --- a/drivers/net/mdio/mdio-bcm-unimac.c
> +++ b/drivers/net/mdio/mdio-bcm-unimac.c
> @@ -351,6 +351,7 @@ static struct platform_driver unimac_mdio_driver = {
>                 .pm = &unimac_mdio_pm_ops,
>         },
>         .probe  = unimac_mdio_probe,
> +       .probe_type = PROBE_FORCE_SYNCHRONOUS,
>         .remove = unimac_mdio_remove,
>  };
>  module_platform_driver(unimac_mdio_driver);

This won't build try this instead:

diff --git a/drivers/net/mdio/mdio-bcm-unimac.c
b/drivers/net/mdio/mdio-bcm-unimac.c
index bfc9be23c973..53fecb53cd65 100644
--- a/drivers/net/mdio/mdio-bcm-unimac.c
+++ b/drivers/net/mdio/mdio-bcm-unimac.c
@@ -349,6 +349,7 @@ static struct platform_driver unimac_mdio_driver = {
                .name = UNIMAC_MDIO_DRV_NAME,
                .of_match_table = unimac_mdio_ids,
                .pm = &unimac_mdio_pm_ops,
+               .probe_type = PROBE_FORCE_SYNCHRONOUS,
        },
        .probe  = unimac_mdio_probe,
        .remove = unimac_mdio_remove,
-- 
Florian


From pbrobinson at gmail.com  Mon Jun 21 09:56:08 2021
From: pbrobinson at gmail.com (Peter Robinson)
Date: Mon, 21 Jun 2021 17:56:08 +0100
Subject: [PATCH] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
In-Reply-To: <35f4baae-a6e1-c87d-279c-74f8c18bb5d1@gmail.com>
References: <20210621103310.186334-1-jhp@endlessos.org>
 <YNCPcmEPuwdwoLto@lunn.ch>
 <35f4baae-a6e1-c87d-279c-74f8c18bb5d1@gmail.com>
Message-ID: <CALeDE9MjRLjTQ1R2nw_rnXsCXKHLMx8XqvG881xgqKz2aJRGfA@mail.gmail.com>

On Mon, Jun 21, 2021 at 5:39 PM Florian Fainelli <f.fainelli at gmail.com> wrote:
>
> On 6/21/21 6:09 AM, Andrew Lunn wrote:
> > On Mon, Jun 21, 2021 at 06:33:11PM +0800, Jian-Hong Pan wrote:
> >> The Broadcom UniMAC MDIO bus comes too late. So, GENET cannot find the
> >> ethernet PHY on UniMAC MDIO bus. This leads GENET fail to attach the
> >> PHY.
> >>
> >> bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
> >> ...
> >> could not attach to PHY
> >> bcmgenet fd580000.ethernet eth0: failed to connect to PHY
> >> uart-pl011 fe201000.serial: no DMA platform data
> >> libphy: bcmgenet MII bus: probed
> >> ...
> >> unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
> >>
> >> This patch makes GENET try to connect the PHY up to 3 times. Also, waits
> >> a while between each time for mdio-bcm-unimac module's loading and
> >> probing.
> >
> > Don't loop. Return -EPROBE_DEFER. The driver core will then probed the
> > driver again later, by which time, the MDIO bus driver should of
> > probed.
>
> This is unlikely to work because GENET register the mdio-bcm-unimac
> platform device so we will likely run into a chicken and egg problem,
> though surprisingly I have not seen this on STB platforms where GENET is
> used, I will try building everything as a module like you do. Can you
> see if the following helps:

For reference we have mdio_bcm_unimac/genet both built as modules in
Fedora and I've not seen this issue reported using vanilla upstream
kernels if that's a useful reference point.

Regards,
Peter


From nsaenzju at redhat.com  Tue Jun 29 05:17:23 2021
From: nsaenzju at redhat.com (Nicolas Saenz Julienne)
Date: Tue, 29 Jun 2021 14:17:23 +0200
Subject: [PATCH] drm/vc4: hdmi: Limit noise when deferring snd card
 registration
Message-ID: <20210629121723.11523-1-nsaenzju@redhat.com>

We don't want to print an error message each time
devm_snd_soc_register_card() returns -EPROBE_DEFER, the function will
most likely succeed some time in the future, once the missing resources
are available. So use dev_err_probe(), which will redirect the messages
to the debug log level in such case.

Signed-off-by: Nicolas Saenz Julienne <nsaenzju at redhat.com>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 04936cd6db8c..32da45821d3a 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1575,7 +1575,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
 	snd_soc_card_set_drvdata(card, vc4_hdmi);
 	ret = devm_snd_soc_register_card(dev, card);
 	if (ret)
-		dev_err(dev, "Could not register sound card: %d\n", ret);
+		dev_err_probe(dev, ret, "Could not register sound card\n");
 
 	return ret;
 
-- 
2.31.1



