[PATCH v2 1/2] pinctrl: bcm2835: Change init order for gpio hogs

Linus Walleij linus.walleij at linaro.org
Thu Dec 9 15:24:05 PST 2021


On Mon, Dec 6, 2021 at 10:22 AM Phil Elwell <phil at raspberrypi.com> wrote:

> ...and gpio-ranges
>
> pinctrl-bcm2835 is a combined pinctrl/gpio driver. Currently the gpio
> side is registered first, but this breaks gpio hogs (which are
> configured during gpiochip_add_data). Part of the hog initialisation
> is a call to pinctrl_gpio_request, and since the pinctrl driver hasn't
> yet been registered this results in an -EPROBE_DEFER from which it can
> never recover.
>
> Change the initialisation sequence to register the pinctrl driver
> first.
>
> This also solves a similar problem with the gpio-ranges property, which
> is required in order for released pins to be returned to inputs.
>
> Fixes: 73345a18d464b ("pinctrl: bcm2835: Pass irqchip when adding gpiochip")
> Signed-off-by: Phil Elwell <phil at raspberrypi.com>

This patch (1/2) applied for fixes.

Yours,
Linus Walleij



More information about the linux-rpi-kernel mailing list