[PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

Nicolas Saenz Julienne nsaenzjulienne at suse.de
Wed Jun 24 10:13:35 EDT 2020


On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service)
> >  
> >  int32_t vchi_service_open(struct vchiq_instance *instance,
> >  	struct service_creation *setup,
> > -	struct vchi_service_handle **handle)
> > +	struct vchi_service **service)
> >  {
> > -	struct shim_service *service = service_alloc(instance, setup);
> > -
> > -	*handle = (struct vchi_service_handle *)service;
> >  
> > +	*service = service_alloc(instance, setup);
> >  	if (service) {
> 
> This should be checking "*service".
> 

Of course, thanks!

Reards,
Nicolas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20200624/cb151e52/attachment.sig>


More information about the linux-rpi-kernel mailing list