[PATCH V2 9/9] staging: vc04_services: Remove stack hog issue from TODO

Stefan Wahren stefan.wahren at i2se.com
Sat Apr 28 08:47:49 PDT 2018

Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.

Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
 drivers/staging/vc04_services/interface/vchi/TODO | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO
index 86708c7..0b3ec75 100644
--- a/drivers/staging/vc04_services/interface/vchi/TODO
+++ b/drivers/staging/vc04_services/interface/vchi/TODO
@@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all
 resouces must be freed (kthreads, debugfs entries, ...) and global
 variables avoided.
-5) Fix stack hog
-Running make checkstack shows that vchiq_dump_service_use_state() has
-an extensive stack usage. Maybe other functions are also affected.
-6) Cleanup logging mechanism
+5) Cleanup logging mechanism
 The driver should probably be using the standard kernel logging mechanisms
 such as dev_info, dev_dbg, and friends.
-7) Documentation
+6) Documentation
 A short top-down description of this driver's architecture (function of
 kthreads, userspace, limitations) could be very helpful for reviewers.

More information about the linux-rpi-kernel mailing list