spi->irq == 0 on module reload of driver using IRQF_TRIGGER_LOW

Andrew Lunn andrew at lunn.ch
Sun Nov 12 10:19:30 PST 2017


> > +&spi {
> > +            status = "okay";
> > +
> > +            can0: mcp2517fd at 0 {
> > +                reg = <0>;
> > +                compatible = "microchip,mcp2517fd";
> > +                pinctrl-names = "default";
> > +                pinctrl-0 = <&can0_pins>;
> > +                spi-max-frequency = <12500000>;
> > +                interrupt-parent = <&gpio>;
> > +                interrupts = <16 0x2>;
> 
> This indicates a falling edge. No wonder the kernel is confused (I
> don't know why this isn't enforced the first time though, probably an
> issue in the GPIO irqchip driver...). Replacing this 2 with a 8 should
> allow you to make some progress.

And using IRQ_TYPE_LEVEL_LOW, from interrupt-controller/irq.h would
make it readable.

     Andrew



More information about the linux-rpi-kernel mailing list