[PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Jun 28 06:04:18 PDT 2017


Hello,

On Wed, Jun 28, 2017 at 12:52:46PM +0100, Phil Elwell wrote:
> On 28/06/2017 11:57, Uwe Kleine-König wrote:
> > nitpick: The order of lines in the Sob area matter and you should add
> > your Sob at the end. So as it was you adding the ack by Eric and Andy,
> > it should look as follows:
> > 
> > 	Acked-by: Eric Anholt <eric at anholt.net>
> > 	Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > 	Signed-off-by: Phil Elwell <phil at raspberrypi.org>
> 
> Really? I thought the submitter went first and the final merger went
> last, with other reviewers in-between, like this:
> 
>     commit 6df765dca378bddf994cfd2044acafa501bd800f
>     Author: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>     Date:   Wed May 24 21:38:46 2017 +0200
> 
>         serial: imx: ensure UCR3 and UFCR are setup correctly
> 
>         [...]
> 
>         Fixes: e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
>         Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>         Acked-by: Mika Penttilä <mika.penttila at nextfour.com>
>         Tested-by: Mika Penttilä <mika.penttila at nextfour.com>
>         Acked-by: Steve Twiss <stwiss.opensource at diasemi.com>
>         Tested-by: Steve Twiss <stwiss.opensource at diasemi.com>
>         Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Right, I would expect that it was Greg who added the Acked and Tested-by
tags when reading this.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-rpi-kernel mailing list