[PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Jun 28 03:57:44 PDT 2017


Hello,

On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote:
> Signed-off-by: Phil Elwell <phil at raspberrypi.org>
> Acked-by: Eric Anholt <eric at anholt.net>
> Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
> Changes in v2:
>  Add review tags.

nitpick: The order of lines in the Sob area matter and you should add
your Sob at the end. So as it was you adding the ack by Eric and Andy,
it should look as follows:

	Acked-by: Eric Anholt <eric at anholt.net>
	Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
	Signed-off-by: Phil Elwell <phil at raspberrypi.org>

. Note that this comment is very picky, quite some people don't get it
right and I never saw a maintainer refuse a patch because of this. So
this probably doesn't warrant a v3 :-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-rpi-kernel mailing list