[PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message
mzoran at crowfest.net
Wed Jan 25 04:33:46 PST 2017
On Wed, 2017-01-25 at 15:10 +0300, Dan Carpenter wrote:
> On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote:
> > The vchi_msg_queue function which is used by other drivers
> > to queue a message is difficult to understand and overly
> > generic. Remove it and replace it with two more specific functions.
> The vc04_services is missing several drivers. It's in the TODO that
> need to merge them. I don't understand why this hasn't happened yet.
> The entire point of staging is that we merge low quality code as-is
> people can clean it up.
> The vchi_msg_queue() function is only used by the out of tree
> The correct thing to do normally would be just to delete it. The
> letter says we delete it, but actually we just make it static and add
> several more unused functions.
> I hate that we're mixing __user and kernel pointers and hiding stuff
> as void pointers. But I can't really review it because it's all out
> Let's first merge the out of tree drivers or let's delete the staging
> code but it's useless to only merge half.
Just for clarity, when you mean staging code? Are you talking about the
entire vc04_services driver or are we talking about the vchi_msg_queue
At this point, vc04_services isn't used by anything in the tree at all.
So if you want all the unused code deleted, well that sounds to me
like you are talking about the whole driver.
I would be more then willing to help upstream the other drivers into
staging for the RPI that actually uses this driver. I just don't know
what the process is for submitting staging drivers.
As for the function, it's still an improvement on the existing which is
what I through the cleanup process in staging was all about.
More information about the linux-rpi-kernel