[PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

Dan Carpenter dan.carpenter at oracle.com
Thu Jan 19 02:10:25 PST 2017

This is hard to review because it's moving stuff around, and changing
stuff and adding new features.  I'll review the v2 patch.

One thing I will say is that I have scripts to review when people pull
parts of an ioctl into a separate patch.  So when you do that, please
don't make too many white space changes if you can avoid it.  Those
confuse my scripts.

The other thing is the new callbacks return true on failure and false on
success.  Stick to negative error codes.  If you're going to make a
boolean function it should be clear from the name that it's boolean.
For example, IS_ERR() is very obviously boolean.

dan carpenter

More information about the linux-rpi-kernel mailing list