[PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler
mzoran at crowfest.net
Wed Jan 18 23:37:55 PST 2017
On Thu, 2017-01-19 at 02:01 +0300, Dan Carpenter wrote:
> On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote:
> > Add the top level compat ioctl handler as a placeholder
> > for adding additional handlers.
> > The ioctls are first filtered and forwarded to the
> > regular ioctl handler if the ioctl does not require
> > any extra compatibility processing.
> > Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> > ---
> > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 73
> > ++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> > diff --git
> > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > index 0525211bcd65..9ade2f63606b 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > @@ -1206,6 +1206,76 @@ vchiq_ioctl(struct file *file, unsigned int
> What the heck??? I feel you're trying to gaslight me now.
> It's unfortunate that this is right at the start of the series
> I've already met my quota of nonsense code and I won't be reviewing
> rest until v2 comes out.
> dan carpenter
This whole driver is a chicken and egg problem. The existing code is
so hard to read and maintain, that it's hard to improve it in a
incremental way. Yet, trowing large sections out the door is too hard
to get seriously reviewed as well...
I would like to think that what I've submitted is an improvement on the
existing stuff. I'm sorry you feel that no changes are possible unless
all the issues are fixed at once.
More information about the linux-rpi-kernel