[PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

Stefan Wahren stefan.wahren at i2se.com
Tue Feb 28 12:18:56 PST 2017


> Michael Zoran <mzoran at crowfest.net> hat am 28. Februar 2017 um 19:49 geschrieben:
> 
> 
> Change the audio's dependency on BCM2835_VCHIQ to a select.
> 
> Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> ---
>  drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
> index b2e6d90ef1cb..479c9e3ace11 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig
> +++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
> @@ -1,7 +1,8 @@
>  config SND_BCM2835
>          tristate "BCM2835 Audio"
> -        depends on ARCH_BCM2835 && BCM2835_VCHIQ && SND
> +        depends on ARCH_BCM2835 && SND
>          select SND_PCM
> +	select BCM2835_VCHIQ
>          help
>            Say Y or M if you want to support BCM2835 built in audio
>  

AFAIK "depends on" is perferred instead of "select", because it's causes less issues. Please explain in the commit messages instead of the cover letter why this patch and patch 3 is necessary.



More information about the linux-rpi-kernel mailing list