[PATCH] bcm2835-audio: Fix checkpatch errors

Man Choy manchoyy at gmail.com
Sun Feb 12 16:49:06 PST 2017


On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
>> Fix following errors:
>>
>> ERROR: do not initialise statics to NULL
>> +static struct snd_card *g_card = NULL;
>>
>> ERROR: do not initialise statics to NULL
>> +static struct bcm2835_chip *g_chip = NULL;
>>
>> Signed-off-by: Man Choy <manchoyy at gmail.com>
>> ---
>>  drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
>> index a84d74d..265fe55 100644
>> --- a/drivers/staging/bcm2835-audio/bcm2835.c
>> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
>> @@ -28,8 +28,8 @@
>>   * to debug if we run into issues
>>   */
>>
>> -static struct snd_card *g_card = NULL;
>> -static struct bcm2835_chip *g_chip = NULL;
>> +static struct snd_card *g_card;
>> +static struct bcm2835_chip *g_chip;
>>
>>  static int snd_bcm2835_free(struct bcm2835_chip *chip)
>>  {
>
> Someone sent this same fix in before you did, a few days ago.  Be sure
> to always use the most up-to-date tree.
>
> sorry,
>
> greg k-h

Please ignore previous email. It contains HTML.

Noted and thanks Greg.

A quick question, I just updated my linux-next tree last night,
checkout tag "next-20170210" and working on the cleanup. How do I
double check my current working file already been updated by someone
else to avoid the duplicate work? As of now, the latest linux-next
tree tag is still "next-20170210"

I am on eudyptula challenge and this is my first attempt to send
kernel patch, sorry about the silly question ;)

MC



More information about the linux-rpi-kernel mailing list