[PATCH] thermal: use upstream bcm2835 thermal driver for arm64

Stefan Wahren stefan.wahren at i2se.com
Thu Aug 31 04:29:18 PDT 2017

Hi Allen,

Am 31.08.2017 um 06:19 schrieb Eric Anholt:
> Allen Wild <allenwild93 at gmail.com> writes:
>> The downstream bcm2835-thermal driver (enabled with THERMAL_BCM2835)
>> doesn't work on the Pi3 in 64 bit mode, but the upstream driver (enabled
>> with BCM2835_THERMAL) can't be enabled for arm64 since the Broadcom
>> Kconfig menu depends on ARCH_BCM which is only for 32-bit ARM.
>> This patch enables the Broadcom thermal drivers Kconfigs for
>> ARCH_BCM2835 and updates the bcmrpi3_defconfig to use the upstream
>> bcm2835 thermal driver.
> This submission probably won't go anywhere, since it's against the
> downstream tree and they're not really watching this list.
> If you'd like to send a pair of patches upstream, one to the thermal
> subsystem for the Kconfig, and one to ARM for the upstream arm64
> defconfig, that would be helpful.  Be sure to use
> scripts/get_maintainers.pl to figure out who you need to Cc, and see
> Documentation/SubmittingPatches for general requirements
> (signed-off-by).

thanks for your patch. But as Eric already pointed out this needs some 
adjustment, before it's merged by the thermal guys.

Additionally here some hints:

* please use branch next from 
as base for your patch
* paraphrase the commit message that your patch fixes the config 
regression which was caused by moving the bcm2835 thermal driver into 
the broadcom directory
   (wording upstream and downstream isn't relevant in this case and 
confuses more that it helps)
* drop the bcmrpi3_defconfig stuff because it doesn't exists in mainline 
* as i mentioned in [1] this commit fixes a regression, so please add 
the following tag

Fixes: 6892cf07e733 ("thermal: bcm2835: move to the broadcom subdirectory")


[1] - https://github.com/raspberrypi/linux/issues/2136

More information about the linux-rpi-kernel mailing list