[PATCH] staging: vc04_services: fix ifnullfree.cocci warnings

kbuild test robot fengguang.wu at intel.com
Fri Nov 11 07:31:46 PST 2016

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c:65:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>

 vchiq_util.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
@@ -61,8 +61,7 @@ int vchiu_queue_init(VCHIU_QUEUE_T *queu
 void vchiu_queue_delete(VCHIU_QUEUE_T *queue)
-	if (queue->storage != NULL)
-		kfree(queue->storage);
+	kfree(queue->storage);
 int vchiu_queue_is_empty(VCHIU_QUEUE_T *queue)

More information about the linux-rpi-kernel mailing list