[alsa-devel] [PATCH 1/2] ASoC: pcm5102a: Add support for PCM5102A codec

Mark Brown broonie at kernel.org
Mon May 23 10:08:53 PDT 2016

On Sun, May 22, 2016 at 11:29:55PM +0200, Emmanuel Fusté wrote:

> There is nothing PCM5102A specific here, and it is pretty generic.
> Wouldn't it be better to write instead a simple-i2s-codec for all the
> classics I2S "hifi" DACs which will get the I2S/DAI parameters from DT ?
> PCM510x, PCM5122 in HW mode, ES9023, a bunch of ES90xx implementations
> etc... will use exactly the same code with only format and rate variation.
> And for the rate, it is implementation dependent, even in the case of
> pcm5102a.

If we do that then we have no idea what the hardware actually is and
we're creating more effort on the DT side, the DT has to specify all 
the parameters for the device rather than just the name.  Given how
trivial the code is it's not clear that this is a win.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20160523/e6a78a9d/attachment.sig>

More information about the linux-rpi-kernel mailing list