[PATCH V4 1/2] clk: bcm2835: mark enabled clocks with CLK_IS_CRITICAL

Eric Anholt eric at anholt.net
Mon May 2 08:36:18 PDT 2016

kernel at martin.sperl.org writes:

> From: Martin Sperl <kernel at martin.sperl.org>
> The bcm2835 firmware enables several clocks and plls before
> booting the linux kernel.
> These plls should never get disabled as it may result in a
> stopped system clock and more.
> So during probing we check if the clock is enabled
> and if it is then mark that clock with CLK_IS_CRITICAL.
> As a consequence this will also enable the corresponding
> parent plls and pll-divs.
> This is intended as a stop-gap until CLK_ENABLE_HAND_OFF
> becomes available, at which point it should be used instead.
> Signed-off-by: Martin Sperl <kernel at martin.sperl.org>

I still think that we don't want this patch.  We should be able to
disable clocks that the firmware turned on, unless they really need to
stay on.  If you have troubles on the upstream DT, let's talk about
individual clocks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20160502/6d3b4a8c/attachment.sig>

More information about the linux-rpi-kernel mailing list