[PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname

Geert Uytterhoeven geert at linux-m68k.org
Tue Apr 19 23:51:23 PDT 2016


On Mon, Apr 11, 2016 at 3:29 PM,  <kernel at martin.sperl.org> wrote:
> From: Martin Sperl <kernel at martin.sperl.org>
>
> Use platform_get_irq_byname to allow for correct mapping of
> interrupts to dma channels.
>
> The currently implemented device tree is unfortunately
> implemented with the wrong assumption, that each dma-channel
> has its own dma channel, but dma-irq 11 is handling
> dma-channel 11-14 and dma-irq 12 is actually a "catch all"
> interrupt.
>
> So here we use the byname variant and require that interrupts
> are explicitly named via the interrupts-name property in the

interrupt-names

> device tree.
>
> The use of shared interrupts is also implemented.

You're not explicitly looking for "dma-shared-all" for that?
You might as well just declare a single unnamed interrupt in the bindings.

> +               /* legacy device tree case handling */
> +               dev_warn_once(&pdev->dev,
> +                             "missing interrupts-names property in device tree - legacy interpretation is used");

interrupt-names

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-rpi-kernel mailing list