[RFC linus/master 2/4] phy: add raspberry pi driver

Alexander Aring alex.aring at gmail.com
Sun Oct 25 00:05:44 PDT 2015


On Sat, Oct 24, 2015 at 09:45:49PM -0600, Stephen Warren wrote:
> On 10/24/2015 06:20 AM, Alexander Aring wrote:
> > This driver adds support for raspberry pi usb phy. This driver just
> > adapt the current infrastructure for usb phys that usb controller uses
> > to power the usb phy via regulators.
> 
> > diff --git a/Documentation/devicetree/bindings/phy/raspberrypi-phy.txt b/Documentation/devicetree/bindings/phy/raspberrypi-phy.txt
> 
> > +RASPBERRY PI USB PHY
> > +
> > +Required properties:
> > + - compatible: raspberrypi,bcm2835-usbphy
> > + - #phy-cells: must be 0
> > + - phy-supply: regulator for the rpi usb phy
> > +Refer to phy/phy-bindings.txt for the generic PHY binding properties
> > +
> > +Example:
> > +
> > +	usbphy: usbphy {
> > +		compatible = "raspberrypi,bcm2835-usbphy";
> > +		#phy-cells = <0>;
> > +		phy-supply = <&usb_hcd_reg>;
> 
> Are you sure this power domain really is related to a USB *PHY*? "HCD"
> usually means "host controller", which is usually separate from a "PHY"
> (or perhaps includes a PHY but is still something more than a PHY).

No, I am not sure. It should more a "dummy" driver then which triggers
the SET_POWER firmware messages, when the "dwc2" driver calls
"phy_power_on/off".

Keeping the name "HCD" was by looking into other GPLv2 projects and look
how the firmware is working. I will rename it to USB then. :-)

- Alex



More information about the linux-rpi-kernel mailing list