[PATCH] Add DT support for PinBall board

Stephen Warren swarren at wwwdotorg.org
Fri Mar 27 21:02:01 PDT 2015

On 03/24/2015 02:55 AM, Gregory Hermant wrote:

An explanation of what the board is would be nice.

> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile

>  dtb-$(CONFIG_BCM2708_DT) += bcm2708-rpi-b.dtb
>  dtb-$(CONFIG_BCM2708_DT) += bcm2708-rpi-b-plus.dtb
> +dtb-$(CONFIG_BCM2708_DT) += bcm2708-pinball.dtb
>  dtb-$(CONFIG_BCM2709_DT) += bcm2709-rpi-2-b.dtb

Alphabetical order would be nice.

> diff --git a/arch/arm/boot/dts/bcm2708-pinball.dts b/arch/arm/boot/dts/bcm2708-pinball.dts

> +/include/ "bcm2708.dtsi"

That file doesn't exist in the upstream kernel. Are you sending this for
inclusion in the RPi Foundation's kernel, or the upstream kernel?

It'd help if you CC'd whoever you want to apply this. If this is a patch
for upstream, you'd also want to CC some mailing lists with wider
distribution, such as the ARM kernel mailing list.

I assume this is a patch for the RPi Foundation's kernel given the DT
name above, and the __overrides__ node at the end, so I won't review the
balance of the patch.

More information about the linux-rpi-kernel mailing list