[PATCH 1/1 RFC] dmaengine: bcm2835: Remove redundant info from channel info

Alexander Stein alexanders83 at web.de
Wed Mar 25 00:19:52 PDT 2015

On Tuesday 24 March 2015 20:12:23, Stephen Warren wrote:
> On 03/24/2015 02:37 PM, Alexander Stein wrote:
> > There is no need to store the DREQ channel additionally in the channel
> > structure. This information is already stored in struct dma_slave_config
> > which is setup by bcm2835_dma_xlate.
> Assuming this passes the smell test of the dmaengine maintainers, and
> you've tested this in the upstream kernel,
> Acked-by: Stephen Warren <swarren at wwwdotorg.org>

That currently my problem: I don't know how to actually test this. Do I need to setup a PCM playback? It seems this is currently the only (cyclic) DMA user in mainline kernel.
And what about that smell test? Is that CONFIG_DMATEST?

Best regards,

More information about the linux-rpi-kernel mailing list