[PATCH] SPI: BCM2835: fix all checkpath --strict messages

Mark Brown broonie at kernel.org
Fri Mar 20 06:40:53 PDT 2015


On Fri, Mar 20, 2015 at 07:26:29AM +0100, Martin Sperl wrote:
> > On 20.03.2015, at 05:58, Stephen Warren <swarren at wwwdotorg.org> wrote:

> > Do you have a list of the warnings this fixes and why? The extra
> > wrapping here looks a bit odd, since the lines before your patch are
> > well under 80 columns.

> scripts/checkpatch.pl --file --terse --strict drivers/spi/spi-bcm2835.c
> drivers/spi/spi-bcm2835.c:182: CHECK: Alignment should match open parenthesis

This is telling you to add more indentation to the second argument not
wrap the first.  Though frankly I don't think it matters - it's
certainly not a routinely followed thing and it frequently makes things
worse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20150320/f077b334/attachment.sig>


More information about the linux-rpi-kernel mailing list