[PATCH] SPI: BCM2835: fix all checkpath --strict messages

Mark Brown broonie at kernel.org
Fri Mar 20 06:36:23 PDT 2015

On Thu, Mar 19, 2015 at 09:01:50AM +0000, kernel at martin.sperl.org wrote:

Looks like I did get these but they took a while to come through...

> -static int bcm2835_spi_start_transfer(struct spi_device *spi,
> -		struct spi_transfer *tfr)
> +static int bcm2835_spi_start_transfer(
> +	struct spi_device *spi,
> +	struct spi_transfer *tfr)

Like Stephen says I'm not 100% sure what issues this is fixing but I
have to say I find the overall result worse.  It's possible the
warning is something reasonable but without knowing what it is it's hard
to say, I do like to see at least the first argument on the same line as
the function name though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20150320/bb50d389/attachment.sig>

More information about the linux-rpi-kernel mailing list