[PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver.
eric at anholt.net
Wed Aug 12 11:04:05 PDT 2015
Michael Turquette <mturquette at linaro.org> writes:
> Hi Eric,
> Quoting Eric Anholt (2015-07-20 12:33:01)
>> +void __init rpi_firmware_init_clock_provider(struct device_node *node)
>> + /* We delay construction of our struct clks until get time,
>> + * because we need to be able to return -EPROBE_DEFER if the
>> + * firmware driver isn't up yet. clk core doesn't support
>> + * re-probing on -EPROBE_DEFER, but callers of clk_get can.
>> + */
>> + of_clk_add_provider(node, rpi_firmware_delayed_get_clk, node);
>> +CLK_OF_DECLARE(rpi_firmware_clocks, "raspberrypi,bcm2835-firmware-clocks",
>> + rpi_firmware_init_clock_provider);
> Do you require CLK_OF_DECLARE here? Could this be a platform driver
I'm not actually sure. The common pattern seemed to be using
CLK_OF_DECLARE (130 files using it versus declaring a struct
platform_driver), and it seems to avoid a whole lot of boilerplate.
What would the advantage be?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 818 bytes
Desc: not available
More information about the linux-rpi-kernel