[PATCH 9/9] ARM: BCM283x: Register fixed clocks for uart in the DT.

Eric Anholt eric at anholt.net
Fri Apr 24 10:06:23 PDT 2015

Stephen Warren <swarren at wwwdotorg.org> writes:

> On 04/21/2015 12:09 PM, Eric Anholt wrote:
>> We were previously relying on the fixed clock registration in
>> clk-bcm2835, but there doesn't seem to be any real reason to not just
>> define it in the DT (and for the 2836 port, I would have needed to
>> change the clock's physical address in clk-bcm2835.c).  Also, because
>> we weren't registering the apb_pclk in clk-bcm2835 as a clock device,
>> we were picking up the uart clock node as apb_pclk by accident.
> Doesn't the following do just that?
> clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT,
>                               126000000);

Nope!  You also need the clk_register_clkdev for the type of lookup
being done by APB to find it.

> Anyway, with this patch, shouldn't we fix drivers/clk/clk-bcm2835.c not
> to register clocks that match those that are added to DT in this patch?
> Actually, to maintain DT ABI (new kernels working with old or new DT),
> we probably need to keep the code in clk-bcm2835.c, but make it
> conditional upon whether there's a clock node in the DT file.

Yeah, I hadn't modified the .c code because of DT ABI
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20150424/388d1819/attachment.sig>

More information about the linux-rpi-kernel mailing list