[PATCH] spi: setting up cs_gpio levels prior to registering spi devices

Martin Sperl kernel at martin.sperl.org
Mon Apr 6 11:37:37 PDT 2015

> On 06.04.2015, at 19:36, Mark Brown <broonie at kernel.org> wrote:
> Please write a series of if statements with continues instead, the above
> block is pretty much illegible with the lack of vertical space, mixture
> of bracketing levels and small indent for the active statement at the
> end.
will do...

> As far as I can tell this code only works for GPIO chip selects?
Correct - unless you want to extend struct spi_master with a new method
to make this generic - maybe at a later point in time...

> Please don't write placeholders like this.
will do - I just was not sure if it is needed or not, so I wanted to make
it explicit to say: maybe we need something here as well...

More information about the linux-rpi-kernel mailing list