[PATCH] gpiolib: fix callers of gpiochip_remove

Linus Walleij linus.walleij at linaro.org
Tue Sep 30 07:11:28 PDT 2014


On Tue, Sep 30, 2014 at 3:24 PM, Arnd Bergmann <arnd at arndb.de> wrote:

> A recent API change made gpiochip_remove return void instead of an
> error value, which broke drivers that use this return value:
>
> gpio/gpio-sch311x.c: In function 'sch311x_gpio_probe':
> gpio/gpio-sch311x.c:286:7: error: void value not ignored as it ought to be
>    if (gpiochip_remove(&priv->blocks[i].chip))
>        ^
>
> This changes the callers that I have found during randconfig testing
> so they no longer depend on the error code.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Fixes: e1db1706c86e ("gpio: gpiolib: set gpiochip_remove retval to void")

Hm AFAICT these are already fixes in my GPIO tree
and linux-next...

Am I looking in the wrong place?

Yours,
Linus Walleij



More information about the linux-rpi-kernel mailing list