[RFC 1/5] bcm2835-mmc: driver for Arasan eMMC IP

Stephen Warren swarren at wwwdotorg.org
Tue Oct 28 18:55:20 PDT 2014

On 10/28/2014 06:00 PM, Piotr Król wrote:
> This is driver for Arasan External Mass Media Controller provided in
> Raspberry Pi single board computer.

We should not have multiple drivers for the same HW. The correct
approach would be to enhance the existing sdhci-bcm2835.c to support any
new features or bug-fixes embodied within this driver. Presumably that
way, you'd also end up with a lot of small feature patches, which would
make patch review easier. Consequently I haven't reviewed this patch much.

Note that Scott Branden at Broadcom appears to be working on the
existing driver; I suggest co-ordinating with him:

[PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops

> diff --git a/drivers/mmc/host/bcm2835-mmc.c b/drivers/mmc/host/bcm2835-mmc.c

> +MODULE_AUTHOR("Gellert Weisz");

There's no signed-off-by for Gellert, nor is the patch author Gellert...

One general comment on the patch: all the timer, thread, ... stuff makes
me wonder if the driver is integrated into the MMC core as well as it
should be; I wonder if the driver is re-implementing stuff that it
should defer to the MMC core?

More information about the linux-rpi-kernel mailing list